[improve][broker] Improve retention endpoint to pure async.
#17496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
added
type/enhancement
gaoran10
requested changes
Sep 20, 2022
| Policies policies = namespaceResources().getPolicies(namespaceName) | ||
| .orElseThrow(() -> new RestException(Status.NOT_FOUND, | ||
| "Namespace policies does not exist")); | ||
| if (!checkQuotas(policies, retention)) { |
There was a problem hiding this comment.
Maybe we can delete this method.
| @@ -1195,12 +1195,16 @@ public void getRetention(@Suspended final AsyncResponse asyncResponse, | |||
| @PathParam("namespace") String namespace) { | |||
| validateNamespaceName(property, cluster, namespace); | |||
| validateNamespacePolicyOperationAsync(namespaceName, PolicyName.RETENTION, PolicyOperation.READ) | |||
| .thenCompose(__ -> getNamespacePoliciesAsync(namespaceName)) | |||
| .thenAccept(policies -> asyncResponse.resume(policies.retention_policies)) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since Pulsar is a fully asynchronous project, we need to avoid using thread-blocking methods.
Also, we can see #14365
Modifications
validatePolicies.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)